tristan/blog-wiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added changes to REF-290-Start

Browse Source
This commit is contained in:
Tristan Ancelet 2023-11-07 14:42:11 -06:00
parent 3eb7c32e49
commit 5ca0fbe588
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
1699375988-ref-209-start.wiki
View File

@ -16,13 +16,16 @@ last 5 posts
*Author:* Tristan Ancelet *Author:* Tristan Ancelet
= REF-209 = = REF-209 =
-----------
Picked up a new ticket. *REF-290: Update Colors on Error Cells*. Picked up a new ticket. *REF-290: Update Colors on Error Cells*.
== What am I doing on it == == What am I doing on it ==
---------------------------
Looks like this is to make make sure all "error" colors displayed (as an outline or as text color) are set to be '#fd6c5a'. Looks like this is to make make sure all "error" colors displayed (as an outline or as text color) are set to be '#fd6c5a'.
=== What Have I done === === What Have I done ===
------------------------
After looking through the layout xml's I see that all of the errorColor's were all set to '#fd6c5a' manually, while '@color/text_error' was defined in colors.xml After looking through the layout xml's I see that all of the errorColor's were all set to '#fd6c5a' manually, while '@color/text_error' was defined in colors.xml
After working on it a bit I poked at my lead (Bobby) to see what the scope of the ticket would include, as I did start going through and manually started changing errorTextColor in each layout that was needing to have it changed (from manual to the global color definition). After working on it a bit I poked at my lead (Bobby) to see what the scope of the ticket would include, as I did start going through and manually started changing errorTextColor in each layout that was needing to have it changed (from manual to the global color definition).
@ -34,10 +37,12 @@ TL;DR:
- @+id/fragment_login_incorrect_details (in fragment_login.xml) - @+id/fragment_login_incorrect_details (in fragment_login.xml)
=== What I have left to do === === What I have left to do ===
------------------------------
I have to test the app and try to get to each individual section to test that each change has actually changed the colors in each area. I have to test the app and try to get to each individual section to test that each change has actually changed the colors in each area.
== People Mentioned In post == == People Mentioned In post ==
------------------------------
| Name | Notes | | Name | Notes |
|:-------------:|-----------| |:-------------:|-----------|